doc: fix indent in tls resumption example#3372
Closed
silverwind wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fix indent in tls resumption example#3372silverwind wants to merge 1 commit intonodejs:masterfrom
silverwind wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
|
LGTM |
silverwind
added a commit
that referenced
this pull request
Oct 15, 2015
Markdown requires 4-space indent to correctly format code blocks. This fixes the example so it's correctly presented as code. PR-URL: #3372 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Contributor
Author
|
Thanks for review, landed in 503f279. |
Contributor
|
Should docfixes also land in LTS? @jasnell |
Member
|
Yes. So long as they're relevant to that branch ;-) |
silverwind
added a commit
that referenced
this pull request
Oct 26, 2015
Markdown requires 4-space indent to correctly format code blocks. This fixes the example so it's correctly presented as code. PR-URL: #3372 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Member
|
Landed in v4.x-staging in e223fc7 |
silverwind
added a commit
that referenced
this pull request
Oct 29, 2015
Markdown requires 4-space indent to correctly format code blocks. This fixes the example so it's correctly presented as code. PR-URL: #3372 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example added in #3147 was wrongly using a 2-space indent, but markdown requires 4-space for code blocks. This fixes it so this code example is now correctly formatted as a code block.